tgravescs commented on a change in pull request #27207:
[WIP][SPARK-18886][CORE] Make Locality wait time measure resource under
utilization due to delay scheduling.
URL: https://github.com/apache/spark/pull/27207#discussion_r377336411
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -469,8 +486,10 @@ private[spark] class TaskSetManager(
extraResources,
serializedTask)
}
+ (taskDescription,
+ taskDescription.isEmpty && maxLocality == TaskLocality.ANY &&
pendingTasks.all.nonEmpty)
Review comment:
actually you can't. You are adding in a check for pendingTasks.all.nonEmpty
and assuming that is all pending tasks. This is new code and wasn't previously
there. You need to look at both pendingTasks and pendingSpeculatableTasks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
