jiangxb1987 commented on a change in pull request #27395: [SPARK-30667][CORE]
Add allGather method to BarrierTaskContext
URL: https://github.com/apache/spark/pull/27395#discussion_r377390579
##########
File path: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala
##########
@@ -99,10 +101,17 @@ private[spark] class BarrierCoordinator(
// reset when a barrier() call fails due to timeout.
private var barrierEpoch: Int = 0
- // An array of RPCCallContexts for barrier tasks that are waiting for
reply of a barrier()
+ // An array of RPCCallContexts for barrier tasks that are waiting for
reply of a blocking
// call.
private val requesters: ArrayBuffer[RpcCallContext] = new
ArrayBuffer[RpcCallContext](numTasks)
+ // An array of allGather messages for barrier tasks that are waiting for
reply of a blocking
+ // call.
+ private val allGatherMessages: ArrayBuffer[Array[Byte]] = new
ArrayBuffer[Array[Byte]](numTasks)
Review comment:
Since performance isn't a major concern here, let's make it collect an array
of String type to keep the code simple.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
