HyukjinKwon commented on a change in pull request #27524: [WIP][SQL] Support
`SimpleDateFormat` and `FastDateFormat` as legacy date/timestamp formatters
URL: https://github.com/apache/spark/pull/27524#discussion_r377421367
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala
##########
@@ -51,41 +52,76 @@ class Iso8601DateFormatter(
}
}
-class LegacyDateFormatter(pattern: String, locale: Locale) extends
DateFormatter {
- @transient
- private lazy val format = FastDateFormat.getInstance(pattern, locale)
+trait LegacyDateFormatter extends DateFormatter {
+ def parseToDate(s: String): Date
+ def formatDate(d: Date): String
override def parse(s: String): Int = {
- val milliseconds = format.parse(s).getTime
+ val milliseconds = parseToDate(s).getTime
DateTimeUtils.millisToDays(milliseconds)
}
override def format(days: Int): String = {
val date = DateTimeUtils.toJavaDate(days)
- format.format(date)
+ formatDate(date)
}
}
+class LegacyFastDateFormatter(pattern: String, locale: Locale) extends
LegacyDateFormatter {
+ @transient
+ private lazy val fdf = FastDateFormat.getInstance(pattern, locale)
+ override def parseToDate(s: String): Date = fdf.parse(s)
+ def formatDate(d: Date): String = fdf.format(d)
Review comment:
`override` seems missed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
