Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4742#discussion_r25241254
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -439,7 +439,14 @@ private[spark] object Utils extends Logging {
executeAndGetOutput(Seq("tar", "-xf", fileName), targetDir)
}
// Make the file executable - That's necessary for scripts
- FileUtil.chmod(targetFile.getAbsolutePath, "a+x")
+ if(isWindows){
+ // Windows does not grant read permission by default to non-admin
users
+ // Add read permission to owner explicitly
+ FileUtil.chmod(targetFile.getAbsolutePath, "u+r")
+ FileUtil.chmod(targetFile.getAbsolutePath, "a+x")
+ } else {
+ FileUtil.chmod(targetFile.getAbsolutePath, "a+x")
--- End diff --
This doesn't need to be in both branches of the `if` right -- this boils
down to just adding `u+r` if `isWindows` and not affecting the current line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
