Ngone51 commented on a change in pull request #27539: [SPARK-30786] [BLOCK
MANAGER] Fix Block replication failure propogation issue in BlockManager
URL: https://github.com/apache/spark/pull/27539#discussion_r377514944
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -666,7 +666,11 @@ private[spark] class BlockManager(
// stream.
channel.close()
val blockSize = channel.getCount
- TempFileBasedBlockStoreUpdater(blockId, level, classTag, tmpFile,
blockSize).save()
+ val blockStored = TempFileBasedBlockStoreUpdater(
+ blockId, level, classTag, tmpFile, blockSize).save()
+ if (!blockStored) {
+ throw new Exception(s"Failure while trying to store block $blockId.")
Review comment:
Shall we add this `BlockManager` info in error message?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
