MaxGekk commented on a change in pull request #27524: [SPARK-30788][SQL]
Support `SimpleDateFormat` and `FastDateFormat` as legacy date/timestamp
formatters
URL: https://github.com/apache/spark/pull/27524#discussion_r377477732
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala
##########
@@ -541,7 +541,7 @@ object Decimal {
/** Maximum number of decimal digits a Long can represent */
val MAX_LONG_DIGITS = 18
- private val POW_10 = Array.tabulate[Long](MAX_LONG_DIGITS + 1)(i =>
math.pow(10, i).toLong)
+ val POW_10 = Array.tabulate[Long](MAX_LONG_DIGITS + 1)(i => math.pow(10,
i).toLong)
Review comment:
`POW_10` is needed in the wrapper of `FastDateFormat` to support
parsing/formatting in microsecond precision. Similar changes were made in Spark
2.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
