Ngone51 commented on a change in pull request #27540: Revert
"[SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue"
URL: https://github.com/apache/spark/pull/27540#discussion_r377524495
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala
##########
@@ -559,9 +559,6 @@ class StringExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
// scalastyle:on
checkEvaluation(StringTrim(Literal("a"), Literal.create(null,
StringType)), null)
checkEvaluation(StringTrim(Literal.create(null, StringType),
Literal("a")), null)
-
- checkEvaluation(StringTrim(Literal("yxTomxx"), Literal("xyz")), "Tom")
- checkEvaluation(StringTrim(Literal("xxxbarxxx"), Literal("x")), "bar")
Review comment:
The order changed in #24902 didn't has affect on constructor
`StringTrim(srcStr, trimStr)` and so test results don't change before/after
#24902. So, I feel it's unnecessary to update parameter order here. And we do
update parameter order in sql test(`string-functions.sql`). WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
