Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4734#discussion_r25259402
--- Diff: dev/run-tests ---
@@ -141,29 +141,41 @@ echo
"========================================================================="
CURRENT_BLOCK=$BLOCK_BUILD
{
+ HIVE_BUILD_ARGS="$SBT_MAVEN_PROFILES_ARGS -Phive -Phive-thriftserver"
+ HIVE_12_BUILD_ARGS="$HIVE_BUILD_ARGS -Phive-0.12.0"
- # NOTE: echo "q" is needed because sbt on encountering a build file with
failure
- # (either resolution or compilation) prompts the user for input either
q, r, etc
- # to quit or retry. This echo is there to make it not block.
- # NOTE: Do not quote $BUILD_MVN_PROFILE_ARGS or else it will be
interpreted as a
- # single argument!
- # QUESTION: Why doesn't 'yes "q"' work?
- # QUESTION: Why doesn't 'grep -v -e "^\[info\] Resolving"' work?
# First build with Hive 0.12.0 to ensure patches do not break the Hive
0.12.0 build
- HIVE_12_BUILD_ARGS="$SBT_MAVEN_PROFILES_ARGS -Phive -Phive-thriftserver
-Phive-0.12.0"
echo "[info] Compile with Hive 0.12.0"
- echo -e "q\n" \
- | build/sbt $HIVE_12_BUILD_ARGS clean hive/compile
hive-thriftserver/compile \
- | grep -v -e "info.*Resolving" -e "warn.*Merging" -e "info.*Including"
+ [ -d "lib_managed" ] && rm -rf lib_managed
+ echo "[info] Building Spark with these arguments: $HIVE_12_BUILD_ARGS"
+
+ if [ "${AMPLAB_JENKINS_BUILD_TOOL}" == "maven" ]; then
+ build/mvn $HIVE_12_BUILD_ARGS clean compile
+ else
+ # NOTE: echo "q" is needed because sbt on encountering a build file
with failure
+ # (either resolution or compilation) prompts the user for input either
q, r, etc
+ # to quit or retry. This echo is there to make it not block.
+ # NOTE: Do not quote $BUILD_MVN_PROFILE_ARGS or else it will be
interpreted as a
+ # single argument!
+ # QUESTION: Why doesn't 'yes "q"' work?
+ # QUESTION: Why doesn't 'grep -v -e "^\[info\] Resolving"' work?
+ echo -e "q\n" \
+ | build/sbt $HIVE_12_BUILD_ARGS clean hive/compile
hive-thriftserver/compile \
+ | grep -v -e "info.*Resolving" -e "warn.*Merging" -e
"info.*Including"
+ fi
# Then build with default Hive version (0.13.1) because tests are based
on this version
echo "[info] Compile with Hive 0.13.1"
- rm -rf lib_managed
- echo "[info] Building Spark with these arguments:
$SBT_MAVEN_PROFILES_ARGS"\
- " -Phive -Phive-thriftserver"
- echo -e "q\n" \
- | build/sbt $SBT_MAVEN_PROFILES_ARGS -Phive -Phive-thriftserver
package assembly/assembly \
- | grep -v -e "info.*Resolving" -e "warn.*Merging" -e "info.*Including"
+ [ -d "lib_managed" ] && rm -rf lib_managed
+ echo "[info] Building Spark with these arguments: $HIVE_BUILD_ARGS"
+
+ if [ "${AMPLAB_JENKINS_BUILD_TOOL}" == "maven" ]; then
+ build/mvn $HIVE_BUILD_ARGS clean compile
--- End diff --
I think the equivalent is `-DskipTests clean package`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
