cloud-fan commented on a change in pull request #27508: [SPARK-30763][SQL] Fix
java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#discussion_r377578737
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##########
@@ -452,6 +452,15 @@ case class RegExpReplace(subject: Expression, regexp:
Expression, rep: Expressio
}
}
+object RegExpExtract {
+ def checkGroupIndex(groupCount: Int, groupIndex: Int): Unit = {
+ if (groupCount < groupIndex) {
+ throw new AnalysisException(
Review comment:
We do this check at runtime, so `AnalysisException` doesn't fit. How about
`IllegalArgumentException`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
