cloud-fan commented on a change in pull request #27539: [SPARK-30786] [CORE]
Fix Block replication failure propogation issue in BlockManager
URL: https://github.com/apache/spark/pull/27539#discussion_r377589484
##########
File path: core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala
##########
@@ -624,6 +624,47 @@ class BlockManagerSuite extends SparkFunSuite with
Matchers with BeforeAndAfterE
assert(store.getRemoteBytes("list1").isEmpty)
}
+ Seq(0, Int.MaxValue - 512).foreach { maxRemoteBlockSizeFetchToMem =>
+ // Trying different values of maxRemoteBlockSizeFetchToMem to test both
+ // non-streaming and streaming flows of Block replication
+ test(s"test for Block replcation retry logic with " +
+ s"maxRemoteBlockSizeFetchToMem: ${maxRemoteBlockSizeFetchToMem}") {
+ val storageLevel = StorageLevel(
+ useDisk = false, useMemory = true, deserialized = true, replication =
3)
+ // Retry replication logic for 2 failures
+ conf.set("spark.storage.maxReplicationFailures", "2")
Review comment:
do we have config entry of it in `org.apache.spark.internal.config`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
