Ngone51 commented on a change in pull request #27539: [SPARK-30786] [CORE] Fix
Block replication failure propogation issue in BlockManager
URL: https://github.com/apache/spark/pull/27539#discussion_r377678687
##########
File path: core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala
##########
@@ -624,6 +624,46 @@ class BlockManagerSuite extends SparkFunSuite with
Matchers with BeforeAndAfterE
assert(store.getRemoteBytes("list1").isEmpty)
}
+ Seq(0, Int.MaxValue - 512).foreach { maxRemoteBlockSizeFetchToMem =>
Review comment:
We could use `Seq(true, false)` instead and name the test as `test for Block
replication retry logic with stream = true/false`. And in the test, we could
have a variable, e.g. `maxRemoteBlockSizeFetchToMem`, to set the size(0,
Int.MaxValue - 512). Thus, the test name could be more understanding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
