Eric5553 commented on a change in pull request #27511: [SPARK-30765][SQL] Refine base operator abstraction code style URL: https://github.com/apache/spark/pull/27511#discussion_r378013963
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala ########## @@ -26,11 +26,12 @@ import org.apache.spark.sql.catalyst.expressions.aggregate.AggregateExpression import org.apache.spark.sql.execution.{SparkPlan, UnaryExecNode} import org.apache.spark.sql.types.{CalendarIntervalType, DateType, IntegerType, TimestampType} -abstract class WindowExecBase( - windowExpression: Seq[NamedExpression], - partitionSpec: Seq[Expression], - orderSpec: Seq[SortOrder], - child: SparkPlan) extends UnaryExecNode { +abstract class WindowExecBase extends UnaryExecNode { + def windowExpression: Seq[NamedExpression] + Review comment: Yea, thanks for the suggestion! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org