cloud-fan commented on issue #24902: [SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue URL: https://github.com/apache/spark/pull/24902#issuecomment-585030960 After checking the codebase, we already support `TRIM ( [ characters FROM ] string )`. My question is: how can we silently change the parameter of an existing SQL function? I don't think this is a correctness issue as the SQL standard doesn't say that the function signature have to be `trim(srcStr, trimStr)`. I agree this was a mistake in the first place, but it has been released and I don't think we can just change it. cc @marmbrus
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
