karuppayya commented on a change in pull request #27539: [SPARK-30786] [CORE]
Fix Block replication failure propogation issue in BlockManager
URL: https://github.com/apache/spark/pull/27539#discussion_r378047386
##########
File path:
core/src/main/scala/org/apache/spark/network/netty/NettyBlockRpcServer.scala
##########
@@ -105,8 +105,14 @@ class NettyBlockRpcServer(
val blockId = BlockId(uploadBlock.blockId)
logDebug(s"Receiving replicated block $blockId with level ${level} " +
s"from ${client.getSocketAddress}")
- blockManager.putBlockData(blockId, data, level, classTag)
- responseContext.onSuccess(ByteBuffer.allocate(0))
+ val blockStored = blockManager.putBlockData(blockId, data, level,
classTag)
+ if (blockStored) {
+ responseContext.onSuccess(ByteBuffer.allocate(0))
+ } else {
+ val exception = new Exception(s"Upload block for $blockId failed.
This mostly happens " +
Review comment:
Instead of a new exception,
Can we use the exception object thrown at
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/storage/BlockManager.scala#L1315?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
