Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/360#discussion_r11932114
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Row.scala
---
@@ -206,6 +206,67 @@ class GenericMutableRow(size: Int) extends
GenericRow(size) with MutableRow {
override def copy() = new GenericRow(values.clone())
}
+// TODO: this is an awful lot of code duplication. If values would be
covariant we could reuse
+// much of GenericRow
+class NativeRow[T](protected[catalyst] val values: Array[T]) extends Row {
--- End diff --
Do we need this class? Arrays don't need to be `Row`s inside of the
execution engine, they only need to be of type `Seq`, and even that
requirements should probably be removed. Instead of NativeRow can we just call
`toSeq` on the Array?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
