MaxGekk commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API URL: https://github.com/apache/spark/pull/27494#issuecomment-585161988 > are there any known behavior changes (bug fixes) caused by this patch? 1. **_millisToDays(millisUtc: Long)_** is called by fromJavaDate() which is used in many places for converting `java.sql.Date` to the number of days since epoch. For example, HiveResult, JDBC, ORC deserializer, Parquet Filters, obviously literals, Hive HadoopTableReader 2. **_millisToDays(millisUtc: Long, timeZone: TimeZone)_** is called from `CurrentBatchTimestamp` (I think we can avoid that), `monthsBetween`, truncTimestamp (we can avoid this by https://github.com/apache/spark/pull/25329) 3. **_daysToMillis(days: SQLDate)_** is called from toJavaDate() which is opposite to fromJavaDate() and is used in the same places. 4. **_daysToMillis(days: SQLDate, timeZone: TimeZone)_** is called from monthsBetween, timestamp trunctions (we can avoid that). **NOTE:** This affects only old dates/timestamps before 1582 year.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
