dongjoon-hyun commented on a change in pull request #27548: [SPARK-30797][SQL]
Set tradition user/group/other permission to ACL entries when setting up ACLs
in truncate table
URL: https://github.com/apache/spark/pull/27548#discussion_r378502882
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -538,12 +539,25 @@ case class TruncateTableCommand(
}
}
optAcls.foreach { acls =>
+ val aclEntries = acls.asScala.filter(_.getName != null).asJava
+
+ // The ACL API also expects the tradition user/group/other
permission
+ // in the form of ACL.
Review comment:
Could you revise a comment to mention that this happens only when the
default ACL configuration doesn't exist?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
