dongjoon-hyun commented on a change in pull request #27548: [SPARK-30797][SQL]
Set tradition user/group/other permission to ACL entries when setting up ACLs
in truncate table
URL: https://github.com/apache/spark/pull/27548#discussion_r378539016
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
##########
@@ -2061,8 +2062,26 @@ abstract class DDLSuite extends QueryTest with
SQLTestUtils {
if (ignore) {
assert(aclEntries.size() == 0)
} else {
- assert(aclEntries.size() == 1)
+ assert(aclEntries.size() == 4)
Review comment:
Technically, this tests the followings.
1. The acls are generated by the permission always.
2. The custom acl is survived without by overwritten by (1).
If the above is your intention, it would be great if you describe that into
the PR description together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
