mridulm commented on a change in pull request #27313: [SPARK-29148][CORE] Add
stage level scheduling dynamic allocation and scheduler backend changes
URL: https://github.com/apache/spark/pull/27313#discussion_r378615294
##########
File path: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala
##########
@@ -726,14 +894,23 @@ private[spark] class ExecutorAllocationManager(
})
}
- registerGauge("numberExecutorsToAdd", numExecutorsToAdd, 0)
+ // The metrics are going to return the numbers for the default
ResourceProfile.
+ // It would be nice to do include each profile somehow in the future.
Review comment:
I saw references to it online, which is why i was curious about existing
semantics.
If it is tied to impl detail, then I agree that removing it might be a good
idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
