chummyhe89 commented on a change in pull request #26984: [SPARK-27641][CORE] 
Fix MetricsSystem to remove metrics of the specific source by exactly match
URL: https://github.com/apache/spark/pull/26984#discussion_r378651573
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
 ##########
 @@ -155,6 +156,12 @@ private[spark] class MetricsSystem private (
     } else { defaultName }
   }
 
+  private[spark] def getRegisteredNames(source: Source): mutable.Set[String] = 
{
 
 Review comment:
   you are right. thanks for your advice.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to