MaxGekk commented on issue #27543: [SPARK-30793][SQL] Fix truncations of 
timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585560123
 
 
   > The code itself looks fine. btw, is this not a correctness issue? (trivial 
though)
   
   I do believe it is a correctness issue. Rounding 2.123 -> 3 doesn't make any 
sense. This is not arithmetic rounding, and not just cutting off the rest. And 
this contradicts to truncations to other levels.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to