WeichenXu123 commented on a change in pull request #27522: [SPARK-30762] Add
dtype=float32 support to vector_to_array UDF
URL: https://github.com/apache/spark/pull/27522#discussion_r378726676
##########
File path: mllib/src/test/scala/org/apache/spark/ml/FunctionsSuite.scala
##########
@@ -77,10 +77,7 @@ class FunctionsSuite extends MLTest {
assert(result3 === expected3)
// Check data types are correct
- df_array_double.schema.fields(0).dataType.simpleString == "array<double>"
- df_array_double.schema.fields(1).dataType.simpleString == "array<double>"
- df_array_float.schema.fields(0).dataType.simpleString == "array<float>"
- df_array_float.schema.fields(1).dataType.simpleString == "array<float>"
+ dfArrayFloat.schema.simpleString ==
"struct<UDF(vec):array<float>,UDF(oldVec):array<float>>"
Review comment:
@liangz1
==> `assert(dfArrayFloat.schema.simpleString ===
"struct<UDF(vec):array<float>,UDF(oldVec):array<float>>")`
* add `assert`
* use `===`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
