iRakson commented on a change in pull request #26863: [SPARK-30234][SQL] ADD 
FILE cannot add directories from sql CLI
URL: https://github.com/apache/spark/pull/26863#discussion_r378763146
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -2147,6 +2147,12 @@ object SQLConf {
       .booleanConf
       .createWithDefault(false)
 
+  val LEGACY_ADD_DIRECTORY_USING_RECURSIVE = 
buildConf("spark.sql.legacy.addDirectory.recursive")
 
 Review comment:
   I guess, it should be `spark.sql.allowAddDirectoryInAddFile` and default set 
to `true`. If default is set to false then we will go back to our previous 
behaviour which do not allow adding directory using `ADD FILE`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to