marmbrus commented on issue #24902: [SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue URL: https://github.com/apache/spark/pull/24902#issuecomment-586025104 Reordering function parameters to match another system, for a method that is otherwise working correctly, sounds exactly like a cosmetic change to me. And as I pointed out, this has been discussed officially on the mailing list. I gave one example, but I can assure you this is not the only one. Don't read just his specific example, but rather also understand the motivation he gives. The Spark project always has been concerned about unnecessary pain being inflicted on users during an upgrade. He encourages us to think about "the tradeoff in terms of creating an update barrier for existing users". I'm also not saying we should *never* silently change behavior. However, in general, silent behavior changes are a big red flag to me. I think they are extra costly to users for the reasons listed above. I believe @cloud-fan is working on collecting a bunch of examples so that he can propose a framework on the mailing list to make sure we evaluate these cases consistently.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
