maryannxue commented on a change in pull request #27509: [SPARK-30764][SQL]
Improve the readability of EXPLAIN FORMATTED style
URL: https://github.com/apache/spark/pull/27509#discussion_r379613391
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
##########
@@ -58,9 +58,9 @@ case class SortMergeJoinExec(
} else "None"
s"""
|(${ExplainUtils.getOpId(this)}) $nodeName
${ExplainUtils.getCodegenId(this)}
- |Left keys : ${leftKeys}
- |Right keys: ${rightKeys}
- |Join condition : ${joinCondStr}
+ |${ExplainUtils.generateFieldString("Left keys", leftKeys)}
Review comment:
No. I meant creating a trait for all physical joins. It'll make pattern
matching easier although we don't have this requirement right now. We could do
it in a follow-up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
