holdenk commented on a change in pull request #26440: [SPARK-20628][CORE][K8S] 
Start to improve Spark decommissioning & preemption support
URL: https://github.com/apache/spark/pull/26440#discussion_r379629794
 
 

 ##########
 File path: 
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
 ##########
 @@ -140,6 +144,16 @@ private[spark] class CoarseGrainedExecutorBackend(
       if (executor == null) {
         exitExecutor(1, "Received LaunchTask command but executor was null")
       } else {
+        if (decommissioned) {
+          logError("Asked to launch a task while decommissioned.")
+          driver match {
+            case Some(endpoint) =>
 
 Review comment:
   So @itskals on Kubernetes and in standalone the driver won't know first (and 
those the only parts implemented in this PR). Certainly, when we go to 
implement YARN support we could try and short circuit talking to the executor 
-- however to enable later things like migrations I'd still want to send the 
message.
   
   This could make a difference when we implement YARN support and I've added a 
note in the design doc so that we don't skip it then.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to