HeartSaVioR commented on a change in pull request #27398: 
[SPARK-30481][DOCS][FOLLOWUP] Document event log compaction into new section of 
monitoring.md
URL: https://github.com/apache/spark/pull/27398#discussion_r379873923
 
 

 ##########
 File path: docs/monitoring.md
 ##########
 @@ -95,6 +95,44 @@ The history server can be configured as follows:
   </tr>
 </table>
 
+### Applying compaction of old event log files
+
+A long-running streaming application can bring a huge single event log file 
which may cost a lot to maintain and
 
 Review comment:
   > I assume this works for any application, not just streaming?
   
   You're right. I focused too much on the target of compaction which is most 
likely streaming application, but in this sentence it's not only for 
`streaming`.
   
   > I also think we should describe what compaction is here up front
   
   Uh, actually we don't have explicit section for rolling event log, hence I 
feel it's good to explain what's rolling event log first, and what is 
"compaction". Otherwise maybe good to have individual section for rolling event 
log?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to