HyukjinKwon commented on a change in pull request #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#discussion_r380012000
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -114,7 +114,29 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
extends Product {
lazy val containsChild: Set[TreeNode[_]] = children.toSet
- private lazy val _hashCode: Int =
scala.util.hashing.MurmurHash3.productHash(this)
+ // Copied from Scala 2.13.1
+ //
github.com/scala/scala/blob/v2.13.1/src/library/scala/util/hashing/MurmurHash3.scala#L56-L73
+ // to prevent the issue https://github.com/scala/bug/issues/10495
+ private final def productHash(x: Product, seed: Int, ignorePrefix: Boolean =
false): Int = {
+ val arr = x.productArity
+ // Case objects have the hashCode inlined directly into the
+ // synthetic hashCode method, but this method should still give
+ // a correct result if passed a case object.
+ if (arr == 0) {
+ x.productPrefix.hashCode
+ } else {
+ var h = seed
+ if (!ignorePrefix) h = scala.util.hashing.MurmurHash3.mix(h,
x.productPrefix.hashCode)
Review comment:
So, only this line is the fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
