cloud-fan commented on a change in pull request #27492: [SPARK-30755][SQL] Update migration guide for HIVE-15167 URL: https://github.com/apache/spark/pull/27492#discussion_r380012529
########## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala ########## @@ -318,7 +318,14 @@ private[hive] class HiveClientImpl( // with the HiveConf in `state` to override the context class loader of the current // thread. shim.setCurrentSessionState(state) - val ret = try f finally { Review comment: does it cover all the cases? e.g. table insertion? This seems only cover the DDL cases. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org