cloud-fan commented on a change in pull request #27601: [SPARK-30847][SQL] Take
productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#discussion_r380033807
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -114,7 +114,29 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
extends Product {
lazy val containsChild: Set[TreeNode[_]] = children.toSet
- private lazy val _hashCode: Int =
scala.util.hashing.MurmurHash3.productHash(this)
Review comment:
can we add a comment? When we drop scala 2.12 and move to scala 2.13, we can
remove this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
