HyukjinKwon commented on a change in pull request #27266: [SPARK-22590][SQL] 
Copy sparkContext.localproperties to child thread in 
BroadcastExchangeExec.executionContext
URL: https://github.com/apache/spark/pull/27266#discussion_r380065226
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala
 ##########
 @@ -73,80 +73,73 @@ case class BroadcastExchangeExec(
 
   @transient
   private[sql] lazy val relationFuture: Future[broadcast.Broadcast[Any]] = {
-    // relationFuture is used in "doExecute". Therefore we can get the 
execution id correctly here.
 
 Review comment:
   I usually don't like such changes. Wonder if we can keep the indentation 
same and make it easier to track the history of commits.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to