HyukjinKwon commented on a change in pull request #27278:
[SPARK-30569][SQL][PYSPARK][SPARKR] Add percentile_approx DSL functions.
URL: https://github.com/apache/spark/pull/27278#discussion_r380073187
##########
File path: python/pyspark/sql/functions.py
##########
@@ -582,6 +582,43 @@ def nanvl(col1, col2):
return Column(sc._jvm.functions.nanvl(_to_java_column(col1),
_to_java_column(col2)))
+@since(3.1)
+def percentile_approx(col, percentage, accuracy=10000):
Review comment:
`accuracy` here too. Let's make it able to take both int and a column
instance. Should be able to do it easily by calling `lit` on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
