vladglinsky opened a new pull request #27603: [SPARK-30851][ML] Add 'path' 
field to the 'LoadInstanceEnd' ML listener event
URL: https://github.com/apache/spark/pull/27603
 
 
   ### What changes were proposed in this pull request?
   Add 'path' field to the 'LoadInstanceEnd' ML listener event.
   
   
   ### Why are the changes needed?
   The 
[LoadInstanceEnd](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/events.scala#L92)
 ML listener event that is added on the scope of SPARK-23674 has no 'path' 
field which makes it impossible to determine from what path an ML instance was 
loaded as well as there is no way to get instance's 'uid' via 
[LoadInstanceStart](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/events.scala#L84)
 event.
   
   The 
[LoadInstanceEnd](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/events.scala#L92)
 must be changed to include 'path' field. Please, refer 
[SaveInstanceStart](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/events.scala#L101)
 and 
[SaveInstanceEnd](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/events.scala#L109)
 events. Both of them have `path` but 
[LoadInstanceStart](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/events.scala#L84)
 and 
[LoadInstanceEnd](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/events.scala#L92)
 are not.
   
   ### Does this PR introduce any user-facing change?
   No.
   
   
   ### How was this patch tested?
   Manually tested and existing unit test modified.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to