Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4770#discussion_r25369132
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -715,12 +715,8 @@ private[spark] object Utils extends Logging {
/** Get the Yarn approved local directories. */
private def getYarnLocalDirs(conf: SparkConf): String = {
- // Hadoop 0.23 and 2.x have different Environment variable names for
the
- // local dirs, so lets check both. We assume one of the 2 is set.
- // LOCAL_DIRS => 2.X, YARN_LOCAL_DIRS => 0.23.X
- val localDirs = Option(conf.getenv("YARN_LOCAL_DIRS"))
- .getOrElse(Option(conf.getenv("LOCAL_DIRS"))
- .getOrElse(""))
+ //YarnLocalDirs must be inside container directory. Since it will be
automatically deleted when container shut downs.
+ val localDirs = Option(System.getProperty("user.dir")).getOrElse(""))
--- End diff --
No, please do not make this change, it's not correct. We do want to use
those env variables, which are set by Yarn and configurable (so, for example,
users can tell apps to use a fast local disk to store shuffle data instead of
whatever disk hosts home directories).
And you do not want the executors files to disappear when it dies. Because
you may be able to reuse shuffle data written by that executor to save the work
of re-computing that data.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
