cloud-fan commented on a change in pull request #27482: [SPARK-30613][SQL]
Support Hive style REPLACE COLUMNS syntax
URL: https://github.com/apache/spark/pull/27482#discussion_r380458080
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -470,9 +470,15 @@ trait CheckAnalysis extends PredicateHelper {
}
}
+ val colsToDelete = mutable.Set.empty[Seq[String]]
Review comment:
This causes conflicts when I backport
https://github.com/apache/spark/pull/27584
I think the change in this file should go into 3.0 as well. Logically
columns deleted should be skipped when checking name duplication for AddColumn.
@imback82 can you open a PR to backport
https://github.com/apache/spark/pull/27584 with changes in this file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
