Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/522#discussion_r11934025
  
    --- Diff: core/src/test/scala/org/apache/spark/JobCancellationSuite.scala 
---
    @@ -101,18 +101,50 @@ class JobCancellationSuite extends FunSuite with 
ShouldMatchers with BeforeAndAf
           sc.parallelize(1 to 10000, 2).map { i => Thread.sleep(10); i 
}.count()
         }
     
    +    // Block until both tasks of job A have started and cancel job A.
    --- End diff --
    
    The diff here is really dumb, I just put the sem.acquire(2) above the 
creation of jobB in this test ("job group") and then copied it to make my test 
("job group with interruption"). The latter test is only different in that I 
sleep for an extraordinarily long amount of time, so that cancellation must 
interrupt the sleep or else make Patrick angry.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to