jiangxb1987 commented on a change in pull request #27072: [SPARK-30404][Core]
Fix wrong log for FetchFailed task's successful speculation
URL: https://github.com/apache/spark/pull/27072#discussion_r381084318
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -879,11 +889,12 @@ private[spark] class TaskSetManager(
}
}
- if (successful(index)) {
- logInfo(s"Task ${info.id} in stage ${taskSet.id} (TID $tid) failed, but
the task will not" +
- s" be re-executed (either because the task failed with a shuffle data
fetch failure," +
- s" so the previous stage needs to be re-run, or because a different
copy of the task" +
- s" has already succeeded).")
+ if (fetchFailedIndex.contains(index)) {
Review comment:
This log info mainly inform the user that we won't re=execute the failed
task, it makes little sense to differentiate between FetchFailed tasks and
speculative tasks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
