Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4773#discussion_r25391907
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ---
@@ -485,7 +485,7 @@ private[spark] class ApplicationMaster(
e.getCause match {
case _: InterruptedException =>
// Reporter thread can interrupt to stop user class
- case e: Exception =>
+ case e: Throwable =>
--- End diff --
`e` still shadows the `e: InvocationTargetException` above. I know it was
already that way in the code and it works as intended this way. However while
we're here I wonder if it's worth calling this variable `cause`? then it's
obvious that `cause` is being rethrown.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
