cloud-fan commented on a change in pull request #27592:
[SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder
URL: https://github.com/apache/spark/pull/27592#discussion_r381136274
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/SetCommand.scala
##########
@@ -115,14 +115,15 @@ case class SetCommand(kv: Option[(String,
Option[String])]) extends RunnableComm
case Some(("-v", None)) =>
val runFunc = (sparkSession: SparkSession) => {
sparkSession.sessionState.conf.getAllDefinedConfs.sorted.map {
- case (key, defaultValue, doc) =>
- Row(key, Option(defaultValue).getOrElse("<undefined>"), doc)
+ case (key, defaultValue, doc, version) =>
+ Row(key, Option(defaultValue).getOrElse("<undefined>"), doc,
version)
Review comment:
what should be the default value? empty string or `<unknown>`? cc
@HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
