cloud-fan commented on a change in pull request #27628: [SPARK-30858][SQL] Make
IntegralDivide's dataType independent from SQL config changes
URL: https://github.com/apache/spark/pull/27628#discussion_r381277017
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
##########
@@ -451,6 +458,12 @@ case class IntegralDivide(left: Expression, right:
Expression) extends DivModLik
override def evalOperation(left: Any, right: Any): Any = div(left, right)
}
+object IntegralDivide {
+ def apply(left: Expression, right: Expression): IntegralDivide = {
+ new IntegralDivide(left, right)
+ }
+}
Review comment:
shall we define `unapply` as well? Most of the time we don't care about the
`returnLong` paramter. When we do, we should write `case e @
IntegralDivide(left, right) if e.returnLong`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
