Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/4602#discussion_r25394294
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -34,24 +35,12 @@ import org.apache.spark.sql.catalyst.expressions._
@DeveloperApi
case class Generate(
generator: Generator,
+ output: Seq[Attribute],
--- End diff --
I agree, the deletion of L42-L54 is duplicated code with the
`logical.Generate`, I would like to keep it unchange for this PR, which aims to
fix the bug.
Definitely we need to refactor the code of `Generator` and `Generate`, but
we can leave it after 1.3 release, what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
