nchammas commented on issue #27534: [SPARK-30879][DOCS] Refine workflow for building docs URL: https://github.com/apache/spark/pull/27534#issuecomment-588424478 > I thought you are aware of the community policies because you have been working in the community for a long time. I thought I was familiar with the policies, too. 😄 > 1. First of all, we don't backport `Improvement`. The decision is made per PR. Understood. And again, just to be clear, I didn't knowingly ask to backport any improvement. > 2. Due to (1), for improvement JIRAs, we had better use the version of master branch for `Affected Version`. In your case, you had better set `3.1.0` clearly when you register as `Improvement`. Perhaps this is part of why I am confused. By setting the "affects version" to 3.0.0 on my ticket, was I technically asking for the improvement to be backported to branch-3.0? This still doesn't explain how branch-2.4 entered the picture, by the way. Is a backport to branch-2.4 implied because 3.0 hasn't been released yet? > 3. For the same ID PRs, we use the same JIRA ID for the related follow-up PRs only. And, in that case, we use `[FOLLOWUP]` tag in the PR title. I wasn't familiar with this convention, but: Duly noted. > Do you think your 3 PRs are follow-ups? For me, those are orthogonal. e.g., `Redefine workflow` is irrelevant to replace the deprecate `Mkdocs` option. The main reason why the committers ask to split is that you put orthogonal things into a single PR. It's bad not only for review, but also for understanding the commit logs. I agree. But just for the record, nobody asked me to split up the PR! I split it up on my own initiative to facilitate review. And in the process of doing that, as we've just seen, I unintentionally made a mess of things... 😅
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
