cloud-fan commented on a change in pull request #27643: [SPARK-30886][SQL] Warn
two-parameter TRIM/LTRIM/RTRIM function usages
URL: https://github.com/apache/spark/pull/27643#discussion_r381896256
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1837,13 +1839,19 @@ class Analyzer(
}
AggregateExpression(agg, Complete, isDistinct, filter)
// This function is not an aggregate function, just return the
resolved one.
- case other =>
- if (isDistinct || filter.isDefined) {
- failAnalysis("DISTINCT or FILTER specified, " +
- s"but ${other.prettyName} is not an aggregate function")
- } else {
- other
+ case other if (isDistinct || filter.isDefined) =>
+ failAnalysis("DISTINCT or FILTER specified, " +
+ s"but ${other.prettyName} is not an aggregate function")
+ case e: String2TrimExpression if arguments.size == 2 =>
+ if (trimWarningEnabled.get) {
+ log.warn("Two-parameter TRIM/LTRIM/RTRIM function
signatures are deprecated." +
Review comment:
TRIM is an operator which can do the work of LTRIM and RTRIM functions as
well, e.g. `TRIM(LEADING trimStr FROM srcStr)` is the same as LTRIM.
There is no FROM syntax for LTRIM and RTRIM as they are just functions.
Shall we deprecate LTRIM and RTRIM completely?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
