Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3916#issuecomment-76114251
@vanzin @pwendell As of the latest changes I think this PR is almost ready
to be merged. An obvious blocker is that the `SparkLauncher` needs to also
handle Windows, but we can fix that easily.
One bigger thing I wanted to clarify is the following: The scope of the
public API this PR currently exposes is narrowed to the extent that
`SparkLauncher` calls a particular distribution's `spark-submit`. IIUC the only
backward compatibility requirement this entails is that we don't remove or
change any of the fields that the `SparkLauncher` sets (e.g. version, master,
app name). Is this correct? This seems like a narrow enough interface to keep
unchanged in future versions of Spark such that merging this will be safe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
