gatorsmile commented on a change in pull request #27646: [SPARK-30892][SQL]
Exclude `spark.sql.variable.substitute.depth` from `removedSQLConfigs`
URL: https://github.com/apache/spark/pull/27646#discussion_r382121967
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2263,8 +2263,6 @@ object SQLConf {
"It was removed to prevent loosing of users data for non-default
value."),
RemovedConfig("spark.sql.legacy.compareDateTimestampInTimestamp",
"3.0.0", "true",
"It was removed to prevent errors like SPARK-23549 for non-default
value."),
- RemovedConfig("spark.sql.variable.substitute.depth", "3.0.0", "40",
Review comment:
Could we add the description in line 2255 and explain which removed
SQLConfigs should NOT be added to removedSQLConfigs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
