MaxGekk commented on a change in pull request #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r382173179
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -321,13 +315,13 @@ object DateTimeUtils {
}
}
- def instantToMicros(instant: Instant): Long = {
+ def instantToMicros(instant: Instant): SQLTimestamp = {
Review comment:
The type aliases are mostly used in DataTimeUtils. Inside of this object, we
know definitely what's timestamps and dates, and which primitive types
represent them.
If you don't mind, I will remove the type aliases at all from DateTimeUtils.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
