MaxGekk commented on a change in pull request #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#discussion_r382243331
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala
##########
@@ -275,9 +275,9 @@ trait GetArrayItemUtil {
if (ordinal.foldable && !ordinal.nullable) {
val intOrdinal = ordinal.eval().asInstanceOf[Number].intValue()
child match {
- case CreateArray(ar) if intOrdinal < ar.length =>
+ case CreateArray(ar, emptyCollection) if intOrdinal < ar.length =>
Review comment:
Is emptyCollection not used, right? You can add unapply to `CreateArray` and
avoid modification of this place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
