imback82 commented on a change in pull request #27642: [SPARK-30885][SQL] V1
table name should be fully qualified if catalog name is provided
URL: https://github.com/apache/spark/pull/27642#discussion_r382392250
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -449,8 +454,17 @@ class ResolveSessionCatalog(
partitionSpec)
case ShowColumnsStatement(tbl, ns) =>
+ if (ns.isDefined && ns.get.length > 1) {
+ throw new AnalysisException(
+ s"Namespace name should have only one part if specified:
${ns.get.quoted}")
+ }
+ val nameParts = if (ns.isDefined && tbl.length == 1) {
+ ns.get ++ tbl
+ } else {
+ tbl
+ }
val sql = "SHOW COLUMNS"
- val v1TableName = parseV1Table(tbl, sql).asTableIdentifier
+ val v1TableName = parseTempViewOrV1Table(nameParts,
sql).asTableIdentifier
Review comment:
`ShowColumnsCommand` works with temp views as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
