imback82 commented on a change in pull request #27650: [SPARK-30902][SQL]
default table provider should be decided by catalog implementations
URL: https://github.com/apache/spark/pull/27650#discussion_r382400491
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -256,6 +256,23 @@ class DataSourceV2SQLSuite
checkAnswer(spark.internalCreateDataFrame(rdd, table.schema), Seq.empty)
}
+ test("CreateTable: without USING clause") {
+ // unset this config to use the default v2 session catalog.
+ spark.conf.unset(V2_SESSION_CATALOG_IMPLEMENTATION.key)
+ val testCatalog = catalog("testcat").asTableCatalog
+
+ sql("CREATE TABLE testcat.t1 (id int)")
+ val t1 = testCatalog.loadTable(Identifier.of(Array(), "t1"))
+ // Spark shouldn't set the default provider for catalog plugins.
+ assert(!t1.properties.containsKey(TableCatalog.PROP_PROVIDER))
+
+ sql("CREATE TABLE t2 (id int)")
Review comment:
Add a test for `CREATE TABLE ... AS SELECT` as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
