cloud-fan commented on issue #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments URL: https://github.com/apache/spark/pull/27495#issuecomment-589540986 I have a new idea. Without considering hint, the rule to match comment is very simple: ``` '/*' (BRACKETED_COMMENT|.)*? '*/' -> channel(HIDDEN) ``` And there is a better way to check if it's hint ``` '/*' (BRACKETED_COMMENT|.)*? '*/' {isHint()}? -> channel(HIDDEN) ``` We can follow `isValidDecimal()` in `Sqlbase.g4` to implement `isHint()`, which checks the first 3 chars and see if they are "/*-"
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
